4364
70%
main: 76%

Ran 18 Nov 2020 09:58AM UTC

Jobs 1

Files 1

Run time 1s

Badge

Embed ▾

Committed 18 Nov 2020 09:32AM UTC coverage: 84.743%. Remained the same

Build # 4364

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Use a fully qualified finalizer name (#946)

* Use a fully qualified finalizer name

In the past we used "hyperconvergeds.hco.kubevirt.io"
as the name of HCO finalizer but it fails on some resources.

Using a fully qualified name like "kubevirt.io/hyperconverged"
and removing the old one if there.

Example:
[stirabos@crc ~]$ oc patch serviceaccounts -n kubevirt-hyperconverged hyperconverged-cluster-operator --type json -p '[{ "op": "add", "path": "/metadata/finalizers", "value": ["hyperconvergeds.hco.kubevirt.io"] }]'
The ServiceAccount "hyperconverged-cluster-operator" is invalid: metadata.finalizers[0]: Invalid value: "hyperconvergeds.hco.kubevirt.io": name is neither a standard finalizer name nor is it fully qualified
[stirabos@crc ~]$ oc patch serviceaccounts -n kubevirt-hyperconverged hyperconverged-cluster-operator --type json -p '[{ "op": "add", "path": "/metadata/finalizers", "value": ["kubevirt.io/hyperconverged"] }]'
serviceaccount/hyperconverged-cluster-operator patched

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

* go fmt

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

Co-authored-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

Run Details

511 of 603 relevant lines covered (84.74%)

26.56 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4364.1	18 Nov 2020 09:58AM UTC	0	84.74	Travis Job 4364.1

Source Files on build 4364

Detailed source file information is not available for this build.

kubevirt / hyperconverged-cluster-operator / 4364
70%
main: 76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4364

kubevirt / hyperconverged-cluster-operator / 4364 70% main: 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4364

kubevirt / hyperconverged-cluster-operator / 4364
70%
main: 76%

README BADGES
x