852
38%

Ran 07 Sep 2015 03:42PM UTC

Jobs 3

Files 23

Run time 90min

Badge

Embed ▾

pending completion

Build # 852

Build Type

Pull #258

travis-ci

Committed by

yungchin

Commit Message

RequestHandler: replace atexit call by finaliser

This fixes a problem where, because RequestHandler instances registered
themselves with atexit, they would always live until program exit.

Having replaced the atexit call with the more usual __del__ finaliser, I
found that this __del__ would never run: the queue-handling thread
instantiated by RequestHandler holds references to self.  Having also
replaced that ref by a weakref, we did get the finaliser to run.

Finally, to make sure we don't block on Queue.get() forever (in which
case the thread still doesn't die), this also adds a timeout to that.

Signed-off-by: Yung-Chin Oei <yungchin@yungchin.nl>

Pull Request Pull Request #258: Get rid of zombie RequestHandler threads

Run Details

21 of 21 new or added lines in 1 file covered. (100.0%)

1729 of 2074 relevant lines covered (83.37%)

2.46 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	87.5	0.0%	pykafka/connection.py
2	97.53	3.01%	pykafka/handlers.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	852.1 (TOXENV=py27 BROKERS=localhost:9092,localhost:9093,localhost:9094 ZOOKEEPER=localhost:2181 KAFKA_BIN=/home/travis/kafka-bin)	07 Sep 2015 05:06PM UTC	23	82.74	Travis Job 852.1
2	852.2 (TOXENV=py34 BROKERS=localhost:9092,localhost:9093,localhost:9094 ZOOKEEPER=localhost:2181 KAFKA_BIN=/home/travis/kafka-bin)	07 Sep 2015 05:09PM UTC	23	81.44	Travis Job 852.2
3	852.3 (TOXENV=pypy BROKERS=localhost:9092,localhost:9093,localhost:9094 ZOOKEEPER=localhost:2181 KAFKA_BIN=/home/travis/kafka-bin)	07 Sep 2015 05:12PM UTC	23	82.16	Travis Job 852.3

Source Files on build 852

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

Parsely / pykafka / 852
38%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 852

Parsely / pykafka / 852 38%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 852

Parsely / pykafka / 852
38%

README BADGES
x