• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

share / sharedb / 1479
97%
master: 97%

Build:
Build:
LAST BUILD BRANCH: dependabot/github_actions/actions/checkout-6
DEFAULT BRANCH: master
Ran 16 Nov 2020 03:50PM UTC
Jobs 3
Files 35
Run time 17s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1479

push

travis-ci

Alec Gibson
Send client handshake when server binds

At the moment, it's possible for the server to miss the client's `hs`
handshake message. Since it never gets the handshake, it never sends one
back, and the client remains uninitialised.

This can happen when performing asynchronous, long-running tasks between
opening the websocket, and calling `backend.listen` to bind the socket
to ShareDB.

This change fixes this issue by having the client send the handshake
message twice:

 - Once when the `Connection` is initialised. If the server is ready,
   but the client connected late, we'll still handshake.
 - Once when the client receives the server's `init` message. If the
   server bound to the socket late, and missed the first handshake
   message, this prompts us to send it again.

1430 of 1652 branches covered (86.56%)

3101 of 3185 relevant lines covered (97.36%)

591.28 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1479.1 16 Nov 2020 03:50PM UTC 0
97.36
Travis Job 1479.1
2 1479.2 16 Nov 2020 03:50PM UTC 0
97.36
Travis Job 1479.2
3 1479.3 16 Nov 2020 03:50PM UTC 0
97.36
Travis Job 1479.3
Source Files on build 1479
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1479
  • 5a39b3b3 on github
  • Prev Build on handshake (#1346)
  • Next Build on handshake (#1481)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc