183725
78%

Ran 10 Nov 2020 09:52PM UTC

Jobs 1

Files 689

Run time 1min

Badge

Embed ▾

Committed 10 Nov 2020 09:52PM UTC coverage: 78.465% (+0.03%) from 78.435%

Build # 183725

Build Type

push

CI-PR build

Committed by GitHub

Commit Message

OnCondition is not correctly caching expressions causing constant expression.Parse calls (#4935)

* GetExpression() was only caching the root expresion parsing, all child conditions which overrode GetExpression() were callin Expression.Parse() on EVERY call, causing us to parse and allocate Expression obejcts every time someone asked for the expression.  This creates a  huge overhead for evaluating triggers.  This was an architectural regression introduced in refactoring in 2019 via commit fe543724, and fixes the problem by having GetExpression() clearly documented as returning a CACHED expression, and moving all creation logic to protected virtual method CreateExpression().  This should be backward compatible with classes which do override this method but there shouldn't be because custom triggers is not something our community has been active in.

* add unit test

* double registerSourceLocation causes exception in OnContinueConversation

* Fix unit test

Run Details

17212 of 21936 relevant lines covered (78.46%)

0.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	183725.2	10 Nov 2020 09:52PM UTC	0	78.46

Source Files on build 183725

Detailed source file information is not available for this build.

microsoft / botbuilder-dotnet / 183725
78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 183725

microsoft / botbuilder-dotnet / 183725 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 183725

microsoft / botbuilder-dotnet / 183725
78%

README BADGES
x