706
83%

Ran 04 Sep 2015 02:21PM UTC

Jobs 10

Files 171

Run time 36min

Badge

Embed ▾

pending completion

Build # 706

Build Type

Pull #498

travis-ci

Committed by

aszlig

Commit Message

ejabberd_c2s: Omit features on required STARTTLS.

According to RFC 6120, section 5.3.1 it's not recommended to send
features before the client has finished STARTTLS:

http://xmpp.org/rfcs/rfc6120.html#tls-rules-mtn

I've stumbled on this with Gajim 0.16.3 on Windows but haven't yet able
to reproduce this with the very same client on NixOS, Ubuntu and Debian.

While this originally was/is an issue with Gajim, MongooseIM really
should implement what is recommended by the RFC, regardless of whether
clients out there break because of this (or see it as an open invitation
to send cleartext passwords).

Signed-off-by: aszlig <aszlig@redmoonstudios.org>

Pull Request Pull Request #498: ejabberd_c2s: Omit features on required STARTTLS.

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

11349 of 21532 relevant lines covered (52.71%)

5654.58 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	77.66	0.0%	apps/ejabberd/src/mod_muc_log.erl

Jobs

ID	Job ID	Ran	Files	Coverage
1	706.1 (PRESET=internal_redis DB=mnesia REL_CONFIG=with-redis)	04 Sep 2015 02:21PM UTC	163	40.0	Travis Job 706.1
2	706.2 (PRESET=internal_mnesia DB=mnesia)	04 Sep 2015 02:22PM UTC	163	40.02	Travis Job 706.2
3	706.3 (PRESET=mysql_mnesia DB=mysql REL_CONFIG=with-mysql)	04 Sep 2015 02:31PM UTC	167	49.1	Travis Job 706.3
4	706.4 (PRESET=odbc_pgsql_mnesia DB=pgsql REL_CONFIG=with-odbc)	04 Sep 2015 02:32PM UTC	163	49.19	Travis Job 706.4
5	706.5 (PRESET=pgsql_mnesia DB=pgsql REL_CONFIG=with-pgsql)	04 Sep 2015 02:33PM UTC	167	48.91	Travis Job 706.5
6	706.6 (PRESET=ldap_mnesia DB=mnesia)	04 Sep 2015 02:47PM UTC	163	43.11	Travis Job 706.6
7	706.7 (PRESET=riak_mnesia DB=riak REL_CONFIG=with-riak)	04 Sep 2015 02:49PM UTC	163	40.5	Travis Job 706.7
8	706.8 (PRESET=external_mnesia DB=mnesia)	04 Sep 2015 02:56PM UTC	163	36.79	Travis Job 706.8
9	706.9 (PRESET=internal_mnesia DB=mnesia)	04 Sep 2015 02:56PM UTC	163	40.3	Travis Job 706.9
10	706.10 (PRESET=internal_mnesia DB=mnesia)	04 Sep 2015 02:57PM UTC	163	38.53	Travis Job 706.10

Source Files on build 706

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

esl / MongooseIM / 706
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 706

esl / MongooseIM / 706 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 706

esl / MongooseIM / 706
83%

README BADGES
x