openwisp / openwisp-notifications / 654

100%

master: 100%

Pull #143

travis-ci

[fix] Fixed stalling of migrate command when celery broker is unreachable #142

Bug:
- The "migrate" management command always stalls when celery broker
  is unreachable
- The underlying cause for this was max_retry_limit of 100 for celery
  publishers. Celery kept retring to push the task on queue with
  waiting time getting incremented on each retry. This was creating an
  illusion that the "migrate" command has stalled.

Solution:
- Decreased max_retry_limit for celery tasks
- Added error handling for the error thrown by celery
  for broker being unreachable
- Added logger to notify errror to the user and provide
  information on resolving the error

Note:
- An active bug in celery does not let the developer to selectively set
  max_retry_limit for a particular task.
  See https://github.com/celery/celery/issues/4627
- In this patch, a workaround is implemented which sets the global
  max_rety_limit. This decreases max_retry_limit for every task.

Fixes #142

10 of 10 new or added lines in 2 files covered. (100.0%)

895 of 895 relevant lines covered (100.0%)

6.0 hits per line