4278
84%
main: 76%

Ran 08 Nov 2020 08:34AM UTC

Jobs 1

Files 1

Run time 1s

Badge

Embed ▾

Committed 08 Nov 2020 07:31AM UTC coverage: 82.585%. Remained the same

Build # 4278

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Distinguish reconciliation requests triggered by the primary resource from ones triggered by others (#919)

Previous all the reconciliation resources were always
enqueued using the the same HyperConverged object
and this was not allowing us to distinguish reconciliation
requests triggered by a change on HCO CR (the primary resource)
from reconciliation requests triggered the other way around
(a change on one of the CRs created and controlled by HCO).

The watch on the primary resource is enqueuing with
InstrumentedEnqueueRequestForObject, while the watches on secondary
resources enque with EnqueueRequestsFromMapFunc so, in this second case,
we can easily set there a placeholder reconcile.Request just to be able
to distinguish the two flows.

With this, each time we are going to reconcile a CR controlled by HCO,
we can distinguish the case where we are updating it due a change
started from HCO CR from the case where we are reconciling it to
overwrite a change directly introduced (by the user?)
on the controlled resource reverting it to an opinionated state.

Let's also add an additional flag (Overwritten) to EnsureResult considering
it as a subset of Updated to be able to report it back to handlers.

Fixing then the log messages and adding relevant unit tests.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Run Details

460 of 557 relevant lines covered (82.59%)

23.17 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4278.1	08 Nov 2020 08:34AM UTC	0	82.59	Travis Job 4278.1

Source Files on build 4278

Detailed source file information is not available for this build.

kubevirt / hyperconverged-cluster-operator / 4278
84%
main: 76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4278

kubevirt / hyperconverged-cluster-operator / 4278 84% main: 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4278

kubevirt / hyperconverged-cluster-operator / 4278
84%
main: 76%

README BADGES
x