joke2k / faker / 3129

96%

push

travis-ci

Fix generation of names ending with spaces (and more) (#1312)

* Test for checking the formats defined in providers

For each locale, for each provider, search all the definitions of "formats"
and make sure that all the providers in there (e.g. {{group}}) are valid
and do not emit empty strings. Empty strings are allows only if the group
is not surrounded by spaces. This is a quick way to make sure that no
string is generated with "double spaces", starting spaces or ending spaces.

* Remove buggy formats

Those formats have been found by test_providers_formats.py:

```
test_no_invalid_formats[de_AT]
E       AssertionError: Errors:
E          - Attribute {{suffix_male}} provided an invalid value in format '{{first_name_male}} {{last_name}} {{suffix_male}}' from faker.providers.person.de_AT.formats
E          - Attribute {{suffix_male}} provided an invalid value in format '{{prefix_male}} {{first_name_male}} {{last_name}} {{suffix_male}}' from faker.providers.person.de_AT.formats
E          - Attribute {{suffix_female}} provided an invalid value in format '{{first_name_female}} {{last_name}} {{suffix_female}}' from faker.providers.person.de_AT.formats
E          - Attribute {{suffix_female}} provided an invalid value in format '{{prefix_female}} {{first_name_female}} {{last_name}} {{suffix_female}}' from faker.providers.person.de_AT.formats

test_no_invalid_formats[fa_IR]
E       AssertionError: Errors:
E          - Attribute {{suffix}} provided an invalid value in format '{{first_name_female}} {{last_name}} {{suffix}}' from faker.providers.person.fa_IR.formats
E          - Attribute {{suffix}} provided an invalid value in format '{{prefix_female}} {{first_name_female}} {{last_name}} {{suffix}}' from faker.providers.person.fa_IR.formats
E          - Attribute {{suffix}} provided an invalid value in format '{{first_name_male}} {{last_name}} {{suffix}}' from faker.providers.person.fa_IR.formats
E          - Attribute {{suffix}} pr... (continued)

1 of 1 new or added line in 1 file covered. (100.0%)

7099 of 7194 relevant lines covered (98.68%)

4.93 hits per line