HEPData / hepdata / 1238

83%

master: 83%

push

travis-ci-com

Fix issue where review messages could not be deleted

This is a workaround for the fact that the db does not define
"ON DELETE CASCADE" for the datareview_messages table.

When deleting a data review object directly, SQLAlchemy cascades the delete
and deletes the associated messages. However, when it's deleted as a result
of a data submission being deleted, SQLAlchemy's lazy loading means that
the data review objects aren't loaded so the associated deletions don't
happen. Instead we directly delete the data reviews in
`receive_before_flush` when a data submission is deleted, which causes
the associated messages to also be deleted.

7 of 7 new or added lines in 1 file covered. (100.0%)

2679 of 3252 relevant lines covered (82.38%)

0.82 hits per line