divio / django-cms / 11180

77%

push

travis-ci

Fix plugin js loading (#6699)

* Added code to load and execute js scripts, with a special class 

The special class is 'cms-execute-js-to-render', and the scripts will only be executed if 
it wasn't present before. If it also has the class 'cms-execute-js-to-render', the 'load' and 'DOMContentLoaded' will be triggered.

* Refactored code to add scripts properly in a method

* Refactored code to only trigger the load events once all is ready

* Added tests for the 4 combinations of the 2 script classes

Since loading behavior of scripts in plugins can be controlled by using this 2 classes

* Added documentation for the new feature

* Added myself to AUTHROS and fixed a typo in docs

* Refactored code to have a more granular control which events get fired

Still need to adapt the docs to this changes

* Adapted documentation to the changes in usable classes

* fixed small spacing bug in the docs

* fixed typos and applied style recommendations

* removed artifact variable 'trigger_window_load_event' and bundled changes

* replacing 'getMultiScript' with 'Promise.all'

as recommended in https://github.com/divio/django-cms/pull/6699#discussion_r354881303

* Rebased on develop branch and rebundled toolbar

35 of 35 new or added lines in 1 file covered. (100.0%)

2553 of 3283 relevant lines covered (77.76%)

33.58 hits per line