inaturalist / iNaturalistAPI / 1165

80%

push

travis-ci

Trusting collection projects (#215)

* Added projects/{id}/membership endpoint
* Show hidden coordinates when viewer curates collection project that the observer trusts
* Make sure project users in fixtures all have IDs
* Added PUT /project_users/:id
* Load observer ProjectUser records for non-trad projects so we can show coords to curators
* Search by private_place_ids in obs search and newProjectsContaining
* Added params.coords_viewable_for_proj param
* Support disabling project trust
* newProjectsContaining works properly with private obs, considers project user_trust preference
* Restored curator access to geo. edge obs from trusting members
* Added by the userSession when building a project obs query, which we need to
  determine inclusion in the project for observations that are privately inside
  but publicly outside the project place boundary
* In addition to allowing curators to see these inclusions, also allowed
  trusting members to see them, but only for their own obs and only in cases
  where they have expressed trust in the project
* Test cases to ensure that the above are true, and that non-trusting members
  and non-members do not see inclusion based on private coordinates
* Extracted place filter for user logic into a separate method to try and make
  this slightly more readable

* Bugfix: only load non_traditional_projects for signed in for a single proj

We're loading full project so we can check to see if they have user trust
enabled when revealing or hiding hidden coordinates, and we only really need to
do that when filtering by a single project.

Co-authored-by: Patrick Leary <patrick.r.leary@gmail.com>

181 of 3202 branches covered (5.65%)

1262 of 5427 relevant lines covered (23.25%)

5.48 hits per line