optimizely / javascript-sdk / 2457

78%

push

travis-ci

feat(flag-decisions): Add support for sending flag decisions (#599)

* Update activate and isFeatureEnabled to send decision events

Include metaData in ImpressionEvent

Send decisions when variation is null

Update existing event_helpers tests

Add metadata to impressionEventParams in getImpressionEventParams method

Add ruleKey parameter to ImpressionEvent

Change experimentKey to ruleKey

Update existing unit tests

Remove sendFlagDecisions from common event params

Update event-processor to include metadata in makeDecisionSnapshot

Update event-processos variationKey type to string | null

Update variationKey type to string | null

Update existing optimizely module tests part 1

Start adding new tests

Update unit tests impression params when decision.experiment is undefined

Clean up

Change layer id type to be string | null

Update variationId to bull as default

* Upgrade event-processor to 0.7.0

* Add createEventProcessor factory function

* Add tests for getSendFlagDecisionsValue method

* Update variationKey type to be string

* Refactor isFeatureEnabled

* Pass decision object instead of 4 individual values

* Update DecisionService setForcedVariation signature and comments

* Use optional chaining and nullish coalescing operator

* Create decision helper functions

* Address comments

* Clean up

* Fix experiment decision object

* Change variation_key to '' instead of null in metadata

* Update Changelog

Co-authored-by: Matt Carroll <matt.carroll@optimizely.com>

838 of 949 branches covered (88.3%)

Branch coverage included in aggregate %.

7648 of 7826 relevant lines covered (97.73%)

408.64 hits per line