4123
81%
main: 76%

Ran 24 Oct 2020 06:32AM UTC

Jobs 1

Files 3

Run time 1s

Badge

Embed ▾

Committed 24 Oct 2020 06:25AM UTC coverage: 80.577%. Remained the same

Build # 4123

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Split operator and webhook into two different pods (#893) (#896)

Currently we are abusing the pod readiness to signal
to OLM that HCO is not ready for an upgrade.
This has a lot of side effects, one of this is the
validating webhook being not able to receive traffic
when exposed by a pod that is not reporting ready=true.
This can cause a lot of side effects if not deadlocks
when the system reach a status where, for any possible
reason, HCO pod cannot be ready and so HCO pod cannot
validate any further update or delete request on HCO CR.
A proper solution is properly use the readiness probe
only to report the pod readiness and communicate
status to OLM via conditions once OLM will be ready for:
https://github.com/operator-framework/enhancements/blob/master/enhancements/operator-conditions.md
in the meanwhile a quick (but dirty!) solution is to
expose the same hco binary on two distinct pods:
the first one will run only the controller and
the second one (almost always ready) just the validating
webhook one.
A deeper code refactor to produce two distinct binaries
is not worth now because we are going to use OLM operator
conditions soon.

Fixes: https://bugzilla.redhat.com/1889401

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Run Details

1340 of 1663 relevant lines covered (80.58%)

39.2 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4123.1	24 Oct 2020 06:32AM UTC	0	80.58	Travis Job 4123.1

Source Files on build 4123

Detailed source file information is not available for this build.

kubevirt / hyperconverged-cluster-operator / 4123
81%
main: 76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4123

kubevirt / hyperconverged-cluster-operator / 4123 81% main: 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4123

kubevirt / hyperconverged-cluster-operator / 4123
81%
main: 76%

README BADGES
x