199
86%

Ran 29 Aug 2015 08:59AM UTC

Jobs 1

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 199

Build Type

push

travis-ci

Committed by

matthew-brett

Commit Message

Merge pull request #348 from matthew-brett/fix-formula-errors

MRG: fix intermittent errors from Formula

Closes gh-258.

Intermittent errors testing Formula, turned out to be from:

* An error I introduced trying to make it easier to use sub-classes with
  Formula add and subtract;
* Unpredictable order of terms after subtraction, caused by use of set to find
  unique terms.

The problem with the add / sub inheritance was that the add and sub methods create a new object at the end, from a list of terms.  By using ``self.__class__`` to construct the output object, I am asserting that the class constructor has the same signature as the Formula class, and that is not true of Factor, which needs a name.

One way round that would be to have a ``from_terms`` method to Formula, and use that, but in fact I don't think its unreasonable to return a Formula from the Factor subtraction, the main logic of the Factor is in the constructor, and combining two factors can make something that isn't a pure Factor.

Run Details

Jobs

ID	Job ID	Ran	Files	Coverage
5	199.5 (COVERAGE=1)	29 Aug 2015 08:59AM UTC	0		Travis Job 199.5

Source Files on build 199

Detailed source file information is not available for this build.

nipy / nipy / 199
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 199

nipy / nipy / 199 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 199

nipy / nipy / 199
86%

README BADGES
x