gnosis / safe-client-gateway / 457

89%

push

travis-ci-com

Submit confirmation through gateway (#167)

* Added confirmation request object, centralised method for parsing ids and general scaffolfings for feature

* Added tests for parse_id method

* refactored ID parsing

* Added id part handler for creation ID and better error handling for when that Id is requested

* Cache invalidation and re-request of the transaction details done

* Updated the error message to something more generic

* Added safe_address to the multisig id parts parsing

* Added converter for backend and service requests for transaction confirmation submission

* Added unit tests to converters

* Removed whitespace

* Error forwarding works

* Error forwarding and request forwarding working as expected

* Cleaned up comment

* Post rebase cleanup

* Returned a 422 in case of a bad id

* ran cargo fmt --all

* PR comments

* Removed Rocket.toml file

3344 of 29743 branches covered (11.24%)

184 of 184 new or added lines in 8 files covered. (100.0%)

2221 of 4146 relevant lines covered (53.57%)

1.96 hits per line