637
72%
master: 32%

Ran 28 Aug 2015 11:44AM UTC

Jobs 2

Files 231

Run time 11s

Badge

Embed ▾

pending completion

Build # 637

Build Type

Pull #173

travis-ci

Committed by

krocard

Commit Message

Normalize unused parameter declaration

When a function parameter is unused, the compilator emits a warning.
There are several wais to avoid that,
and thus express that this parameter is rightfully unused.

 1) remove the unused parameter warning
    => but their are errors when that would be hided
 2) declare de parameter as __attribute__((unused))
    => but it is gcc/clang specific
 3) use the parameter in a no-op operation
    (usually by casting it to void)
    => but using the parameter declared as unused by this mean
       will not trigger an error
 4) remove the parameter identifier (leaving the type) from the function
    => but when the name is non redundant with the type,
       this looses information and thus make review harder.
 5) comment the parameter identifier
    => no drawback

As a result it has been chosen to normalize all unused parameters
with the 5th solution.
For identifiers that are a repetition of their type have been removed (4).

Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>

Pull Request Pull Request #173: Normalize unused parameter declaration

Run Details

5078 of 6976 relevant lines covered (72.79%)

3975.97 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	637.1	28 Aug 2015 11:44AM UTC	231	72.79	Travis Job 637.1
2	637.2	28 Aug 2015 11:44AM UTC	231	0.0	Travis Job 637.2

Source Files on build 637

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

01org / parameter-framework / 637
72%
master: 32%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 637

01org / parameter-framework / 637 72% master: 32%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 637

01org / parameter-framework / 637
72%
master: 32%

README BADGES
x