174757
78%

Ran 15 Oct 2020 02:53PM UTC

Jobs 1

Files 687

Run time 2min

Badge

Embed ▾

Committed 15 Oct 2020 02:53PM UTC coverage: 77.792% (+0.03%) from 77.758%

Build # 174757

Build Type

push

CI-PR build

Committed by GitHub

Commit Message

Adds support for skills without AppId and password in emulator. (#4757)

* Adds support for skills without AppId and password in emulator.
Updated ChannelServiceHanlder to add an anonymous skill AppId claim when auth is disabled.
Updated AppCredentials.ShouldSetToken() logic to avoid sending a token when the AppId is not set or when it is set to the anonymous skill appId.
Update SkillValidation.IsSkillClaim to return true for anonymous skills.
Added AuthenticationConstants.AnonymousSkillAppId constant.
Added unit tests for new logic.

* Updated comment

* Added constant for AuthenticationConstants.AnonymousAuthType (set to anonymous) and replaced usages

* Introduced new skill constant in RoleTypes.
Updated BotFrameworkHttpClient to set the role of the recipient of the outgoing activity clone to RoletTypes.Skill
Updated JwtTokenValidation to check for the Role if the incoming activity instead of checking for RelatesTo
Updated tests

* Reverted changes to schemas

* Update RoleTypes.cs

Touched the file to force a new build

* Fixed file format

* Ported changes from JwtTokenValidation to ParameterizedBotFrameworkAuthentication

* Added a SkillValidation.CreateAnonymousSkillClaim)( method to centralized logic to create the anonoymous claims and updated related code.

* Touched to trigger another build

Run Details

17006 of 21861 relevant lines covered (77.79%)

0.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	174757.2	15 Oct 2020 02:53PM UTC	0	77.79

Source Files on build 174757

Detailed source file information is not available for this build.

microsoft / botbuilder-dotnet / 174757
78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 174757

microsoft / botbuilder-dotnet / 174757 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 174757

microsoft / botbuilder-dotnet / 174757
78%

README BADGES
x