prometheus / client_ruby / 661

100%

master: 100%

push

travis-ci

<a href="https://github.com/prometheus/client_ruby/commit/<a class=hub.com/prometheus/client_ruby/commit/d14e4dd1aee95791ddb69c9e7ce632305c013c91">d14e4dd1a<a href="https://github.com/prometheus/client_ruby/commit/d14e4dd1aee95791ddb69c9e7ce632305c013c91">&quot;&gt;Include SCRIPT_NAME when determining path in Collector

When determining the path for a request, `Rack::Request` prefixes the
`SCRIPT_NAME`, [as seen here][1].

This is a problem with our current code when using mountable engines,
where the engine part of the path gets lost.

This patch fixes that to include `SCRIPT_NAME` as part of the path.

NOTE: This is not backwards compatible. Labels will change in existing
metrics. We will cut a new major version once we ship this.

[1]: https://github.com/rack/rack/blob/</a><a class="double-link" href="https://github.com/prometheus/client_ruby/commit/<a class="double-link" href="https://github.com/prometheus/client_ruby/commit/294fd239a71aab805877790f0a92ee3c72e67d79">294fd239a</a>">294fd239a</a><a href="https://github.com/prometheus/client_ruby/commit/d14e4dd1aee95791ddb69c9e7ce632305c013c91">/lib/rack/request.rb#L512

1577 of 1577 relevant lines covered (100.0%)

45.71 hits per line