reanahub / reana-job-controller / 970

47%

master: 47%

push

travis-ci

slurm: reace condition when consulting job state

* Because job IDs are reused in the Slurm DB when we consult the state
  of a job very quickly we get the state of an old job with the same
  ID which tipically is `COMPLETED`, causing REANA to think it is done
  and then try to find the output files (which do not exist because
  the actual job didn't finished).

  Technically speaking `sacct` queries `slurmdbd` but the job we submitted
  is still in memory only (`slurmctld`) and not yet committed to DB
  (`slurmdb`), where the old job ID lays (with its old information).

  This commit fixes the problem by using `scontrol show job` because it
  uses `slurmctld` directly and has the latest data (closes #272).

3 of 3 new or added lines in 1 file covered. (100.0%)

450 of 963 relevant lines covered (46.73%)

0.47 hits per line