isaacgr / jaysonic / 97

95%

push

travis-ci-com

Improve code maintainability based on codeclimate output (#73)

* Move client and server to more correct factory/protocol method
* Fix code climate errors to remove duplicate code and reduce complexity
* Get tests working with new protocol/factory classes
* Reorganize batch response handling
* Remove pendingBatches and just use pendingCalls
* Fix tcp and ws timeout test
* Raise error with null id if unable to parse message response
* Update tests for null id from parse error response
* Base client no longer uses this.listeners
* Update max method lines and cognitive complexity thresholds for codeclimate
* Add setConnector method so browser client doesnt attempt to import node modules
* Handle empty array request per spec and add a test
* Improve ws and tcp reconnect methods.

191 of 246 branches covered (77.64%)

Branch coverage included in aggregate %.

596 of 674 relevant lines covered (88.43%)

129.07 hits per line