cuthbertLab / music21 / 2617

93%

push

travis-ci

Change instrumentLookup to use simple names (#631)

* Update instrumentLookup.py

Makes allToBestName from the consituent dicts to ensure consistency. Adds test for the same.

* Update instrumentLookup.py

Move import statement to top;
Empty line lint.

* Update instrumentLookup.py

Adds bass trombone;
Removes unused 'bestNameToLanguage' dict

* Update instrumentLookup.py

Iterate the dictionary directly

* Update instrument.py

saxofono tenor[e]

* Update instrumentLookup.py

Saxonofone types;
Special case of transliteration via the relevant language

* Update instrumentLookup.py

Reinstate a few cases that were in the former allToBestName and not in any of the constituent dicts (a good sign that building from the combined form is needed for consistency.)
TODO: more systemtic handling e.g. of plurals

* Fix lints and make English names authoritative

* Update instrument.py

1. Introduces and implements the following variables (as explained in the expanded docs):
    * hardLimitOnLowest
    * hardLimitOnHighest
    * meanPitch

2. Adds Contrabassoon

3. Transpositions. This warrants a small essay ;)

Most instruments seem to have their lowest note given in written pitch along with the (most typical) transposition interval.

For instance,

Clarinet:
        self.lowestNote = pitch.Pitch('E3')
        self.transposition = interval.Interval('M-2')
The transposition indicates that we're working with a Bb clarinet by default, in which case the lowest pitch is certainly the written pitch (sounding D3).

Likewise the Bass Clarinet:
        self.lowestNote = pitch.Pitch('E-3')
        self.transposition = interval.Interval('M-9')
Again, with this (standard) transposition, this lowest pitch most likely indicated written pitch (sounding D-2).

I'm not altogether convinced that this is the best system, especially when we get to the double bass, for which the doc comments read:
'For the Contrabass (or do... (continued)

43 of 43 new or added lines in 2 files covered. (100.0%)

70251 of 77319 relevant lines covered (90.86%)

0.91 hits per line