SibylLab / Program-Wars / 1317

51%

push

travis-ci

Steves final summer bug fixes (#638)

* Made some changes to CardFactory to reduce the size of the if statement in newCard. Fixed a bug in isNegativeEffect in card data so that Trojan is not confused as a negative effect. Added tests for card factory newCard.

* Testing for the Card class.

* Add tests for CardWrapper.

* Fixed a mistake with how I was testing CardWrapper constructor. Added Tests for instruction card class.

* Added Method card class tests.

* Configured jest to not look in the documents folder.

* Added MimicWrapper tests, and started Repeat tests.

* Added Repeat class tests.

* Added tests for Search and Sort cards.

* Added tests for Virus card.

* Added tests for Redraw handler.

* Started adding back PlayBestCard tests.

* Added more tests for PlayBestCard.

* Added tests for Virus in play best card. Updated this to call willAccept on the stacks, so an AI can't play a virus on a stack with a virus.

* Added test for search and added to only search the top n cards set by the search cards value. Also, fixed an issue with the loop that would never find a card.

* Added tests for seach and sort. Adjusted sort as drawing cards from the deck should never be undefined.

* Finished testing the PlayBestCard class. also set up play negative effect to not need scores as players have these attached to them now. Have not removed it from the rest of the game yet though.

* Added tests for AIHandler.

* Added test for action handler which is essentially an abstract class. Added deck to the params of handle and it is everywhere else.

* Added back the aiHelpers tests as the file hasn't changed.

* Added tests for play random card. Fixed the search in random card to use the card value or the length of the deck to bound the choice.

* Since we made PlayBestCard instruction method only play on the method stack, I am removing the MethodStackFirst component.

* Added test for AIHandlerFactory and fixed som... (continued)

257 of 512 branches covered (50.2%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 3 files covered. (100.0%)

619 of 1199 relevant lines covered (51.63%)

38.02 hits per line