• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

optimizely / javascript-sdk / 2366
78%

Build:
DEFAULT BRANCH: master
Ran 06 Oct 2020 05:52PM UTC
Jobs 7
Files 65
Run time 34min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2366

push

travis-ci

web-flow
fix(project config manager): Don't log an error when not initialized with datafile (#589)

Summary:

Fixes a regression introduced during refactoring for datafile accessor - any time the datafile property of the object passed to createInstance is missing or falsy, the logger will output (for example):

[OPTIMIZELY] - ERROR 2020-10-05T23:38:15.224Z CONFIG_VALIDATOR: No datafile specified. Cannot start optimizely

Passing in an sdkKey, but no datafile, is valid and supported when calling createInstance, but this message leads the user to believe otherwise. In this situation, nothing is actually wrong, but the message says "Cannot start optimizely".

To fix, in ProjectConfigManager __initialize, when config.datafile is falsy, we do not call __handleNewDatafile, avoiding the code path that eventually would log the error message.

Test plan:

- Added new unit test
- Manually tested

804 of 918 branches covered (87.58%)

Branch coverage included in aggregate %.

7542 of 7719 relevant lines covered (97.71%)

408.5 hits per line

Jobs
ID Job ID Ran Files Coverage
2 2366.2 (BROWSER_STACK_USERNAME=[secure] BROWSER_STACK_ACCESS_KEY=[secure] SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 06 Oct 2020 05:52PM UTC 0
96.63
Travis Job 2366.2
5 2366.5 (BROWSER_STACK_USERNAME=[secure] BROWSER_STACK_ACCESS_KEY=[secure] SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 06 Oct 2020 06:14PM UTC 0
96.63
Travis Job 2366.5
6 2366.6 (BROWSER_STACK_USERNAME=[secure] BROWSER_STACK_ACCESS_KEY=[secure] SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 06 Oct 2020 06:20PM UTC 0
96.63
Travis Job 2366.6
7 2366.7 (BROWSER_STACK_USERNAME=[secure] BROWSER_STACK_ACCESS_KEY=[secure] SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 06 Oct 2020 06:20PM UTC 0
96.63
Travis Job 2366.7
8 2366.8 (BROWSER_STACK_USERNAME=[secure] BROWSER_STACK_ACCESS_KEY=[secure] SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 06 Oct 2020 06:20PM UTC 0
96.63
Travis Job 2366.8
9 2366.9 (BROWSER_STACK_USERNAME=[secure] BROWSER_STACK_ACCESS_KEY=[secure] SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 06 Oct 2020 06:20PM UTC 0
96.63
Travis Job 2366.9
10 2366.10 (BROWSER_STACK_USERNAME=[secure] BROWSER_STACK_ACCESS_KEY=[secure] SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 06 Oct 2020 06:26PM UTC 0
96.63
Travis Job 2366.10
Source Files on build 2366
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2366
  • 2817a4b9 on github
  • Prev Build on master (#2364)
  • Next Build on master (#2371)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc