twitter / util / 198

38%

push

travis-ci

util-hashing, finagle-memcached: Improve performance

Problem

Performance of cache clients can be optimized in terms
or CPU and allocations.

Solution

* finagle-memcached: Introduce `NotFound` which can be faster
  in some cases than `keys -- hits` for calculating cache misses.

* finagle-memcached: Constants for `c.t.f.memcachedx.protocol.Response`
  objects.

* finagle-memcached: Constant for `GetResult.Empty`

* finagle-memcached: Prefer "builders" when constructing
  immutable data structures.

* finagle-memcached: `KeyValidation.init` lifted the key validation
  function and improve `invalidByteIndex`.

* util-hashing: Avoid wrapping in an unnecessary `ByteBuffer` in
  `Hashable.MD5_LEInt`.

* util-hashing: Avoid unnecessary `Option` creation in
  `KetamaDistributor.mapEntryForHash`.

Result

Improved allocations in a production use case.

RB_ID=731829

23 of 23 new or added lines in 3 files covered. (100.0%)

4940 of 7544 relevant lines covered (65.48%)

3.87 hits per line