Gallopsled / pwntools / 4327
74%

DEFAULT BRANCH: dev
Ran
Jobs 2
Files 143
Run time 25s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4327

push

travis-ci

web-flow 
I386 ascii shellcode (#1667)

* Add module ascii_shellcode

* Add doctests

* Make the ascii_shellcode module accessible from pwn star import

* Remove unused imports

* Update docstr

* Update CHANGELOG.md

* Also test private functions

* Undo accidental modification of CHANGELOG.md

* Fix python 2

* Fix python 2 doctests

* Use bytes object in doctests instead of converting from/to hex strings

* Add doctest to shellcraft>asciify>run shellcode

* Move to pwnlib.encoders.i386

* Fix python 2

* Apply some of the suggestions from Arusekk's code review

Co-authored-by: Arusekk <arek_koz@o2.pl>

* Fix some broken code from the suggestions

https://github.com/Gallopsled/pwntools/pull/1667#discussion_r491699166
https://github.com/Gallopsled/pwntools/pull/1667#discussion_r491700154
https://github.com/Gallopsled/pwntools/pull/1667#discussion_r491700397

* Beautify code by using bytearrays everywhere

https://github.com/Gallopsled/pwntools/pull/1667#discussion_r491698062
https://github.com/Gallopsled/pwntools/pull/1667#discussion_r491701007
https://github.com/Gallopsled/pwntools/pull/1667#discussion_r491700313
https://github.com/Gallopsled/pwntools/pull/1667#discussion_r491700853
https://github.com/Gallopsled/pwntools/pull/1667#discussion_r491698916
https://github.com/Gallopsled/pwntools/pull/1667#discussion_r491699243

* Fix python2 doctests

Forgot to update a few doctests to use bytearrays instead of bytes

* Try to improve test coverage

Test correctness of avoid parameter processing

* Remove unused imports

Co-authored-by: Arusekk <arek_koz@o2.pl>

2962 of 5984 branches covered (49.5%)

83 of 83 new or added lines in 2 files covered. (100.0%)

9878 of 15458 relevant lines covered (63.9%)

1.27 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
4
95.12
 pwnlib/encoders/i386/ascii_shellcode.py

Uncovered Existing Lines

Lines Coverage ∆ File
1
76.52
 -0.95% pwnlib/log.py
3
75.0
 -25.0% pwnlib/device.py
3
76.33
 -1.31% pwnlib/elf/elf.py
4
79.41
 -11.76% pwnlib/commandline/main.py
4
67.38
 -1.54% pwnlib/tubes/process.py
5
86.87
 -1.76% pwnlib/asm.py
5
42.11
 -13.16% pwnlib/atexception.py
5
61.11
 -27.78% pwnlib/commandline/checksec.py
5
55.0
 -25.0% pwnlib/commandline/unhex.py
5
45.59
 -10.58% pwnlib/encoders/encoder.py
6
90.71
 -1.86% pwnlib/util/fiddling.py
7
58.82
 -41.18% pwnlib/commandline/hex.py
8
63.22
 -9.2% pwnlib/args.py
9
82.61
 -9.94% pwnlib/term/text.py
11
20.91
 -3.33% pwnlib/term/readline.py
13
50.0
 -50.0% pwnlib/commandline/common.py
14
32.14
 -50.0% pwnlib/commandline/errno.py
14
83.38
 -3.8% pwnlib/fmtstr.py
14
69.61
 -6.58% pwnlib/memleak.py
16
42.31
 -30.77% pwnlib/commandline/asm.py
17
70.73
 -13.95% pwnlib/shellcraft/__init__.py
20
38.78
 -40.82% pwnlib/commandline/cyclic.py
20
42.86
 -47.62% pwnlib/commandline/disasm.py
23
76.48
 -6.38% pwnlib/context/__init__.py
25
74.24
 -5.85% pwnlib/tubes/tube.py
26
25.0
 -54.17% pwnlib/term/unix_termcap.py
27
36.0
 -54.0% pwnlib/term/__init__.py
28
41.18
 -54.9% pwnlib/commandline/phd.py
33
0.0
 -89.19% pwnlib/lexer.py
38
31.03
 -65.52% pwnlib/commandline/constgrep.py
78
49.7
 -47.27% pwnlib/ui.py
112
20.35
 -65.12% pwnlib/commandline/shellcraft.py
123
23.1
 -37.39% pwnlib/term/key.py
162
29.47
 -51.65% pwnlib/protocols/adb/__init__.py
234
11.09
 -52.61% pwnlib/dynelf.py
255
12.98
 -54.26% pwnlib/term/term.py
349
22.34
 -53.35% pwnlib/adb/adb.py
Jobs
ID Job ID Ran Files Coverage
1 4327.1 143
63.6
 Travis Job 4327.1
2 4327.2 143
64.23
 Travis Job 4327.2
Source Files on build 4327