3981
73%

Ran 24 Sep 2020 01:22PM UTC

Jobs 1

Files 226

Run time 22s

Badge

Embed ▾

pending completion

Build # 3981

Build Type

cron

travis-ci

Committed by

web-flow

Commit Message

Allow string argument in AbstractUpdateAction::setRefresh (#1791)

Ref #1475 

Currently, `AbstractUpdateAction::setRefresh` only accepts boolean values: 
- `true` - to perform an immediate refresh
- `false` - to not refresh at all

The [documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-refresh.html), however, strongly suggests the usage of `wait_for` option to ensure a good cluster performance while doing the refresh operation. But the problem is that `wait_for` is of type `string`; thus, we cannot pass it as an argument to the method.

This modifies `AbstractUpdateAction::setRefresh` so that arguments of type `string` such as `wait_for` can also be passed to the method. Additionally, the return type of its getter counterpart, `AbstractUpdateAction::getRefresh`, has also been modified to mirror the accepted types of the setter.

Run Details

3116 of 4247 relevant lines covered (73.37%)

53.82 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	3981.5 (RUN_TEST=coverage COMPOSER_FLAGS="--prefer-stable --prefer-lowest" ES_VERSION=73)	24 Sep 2020 01:19PM UTC	0	73.37	Travis Job 3981.5

Source Files on build 3981

Detailed source file information is not available for this build.

ruflin / Elastica / 3981
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3981

ruflin / Elastica / 3981 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3981

ruflin / Elastica / 3981
73%

README BADGES
x