12996
66%
master: 66%

Ran 23 Sep 2020 04:12PM UTC

Jobs 1

Files 114

Run time 24s

Badge

Embed ▾

Committed 23 Sep 2020 04:01PM UTC coverage: 65.305% (+0.05%) from 65.256%

Build # 12996

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Fix IsAnyNilOrZero to correctly handle all numeric types (#5096)

The previous implementation of `IsAnyNilOrZero` did not in fact work,
and its tests did not catch this fact. Within the numeric clause, the
compiler would only instantiate the comparison literal 0 to be one
of the eight possible types. Comparisons against any of the other
seven types would always be false, no matter what value that type
held.

The tests did not catch this because they only tested two literal
values: `0` and `-12.345`, both of which can be `float64`s.

This change updates the utility function to use the `reflect` package,
to ensure that it works correctly. It also updates the test to test
multiple different kinds of numeric values, and removes the code
for handling pointer-to- types, as all of our proto2 code has been
removed.

Finally, it updates the SA wrapper's `RevokeCertificate` method to
correctly not require that `req.Reason` be non-zero: this field can
and often is zero, as that value represents `Unspecified`.

Using the reflect package is a conscious tradeoff. It will be slower
than manually writing out every single case, but it will also be less
prone to error.

Part of #5097

Run Details

13240 of 20274 relevant lines covered (65.31%)

0.73 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
7	12996.7 (RUN="coverage" CONTAINER="netaccess")	23 Sep 2020 04:12PM UTC	0	65.31	Travis Job 12996.7

Source Files on build 12996

Detailed source file information is not available for this build.

letsencrypt / boulder / 12996
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12996

letsencrypt / boulder / 12996 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12996

letsencrypt / boulder / 12996
66%
master: 66%

README BADGES
x