• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ICRAR / ngas / 434
69%
master: 69%

Build:
Build:
LAST BUILD BRANCH: config_use_prepared_stmts_for_clients
DEFAULT BRANCH: master
Ran 21 Sep 2020 09:44AM UTC
Jobs 3
Files 163
Run time 22s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
434

push

travis-ci-com

rtobar
Modify proxy_request to work in streaming mode

As pointed out in #29, the previous implementation of proxy_request
accumulated the proxy's response before it was sent back to the original
client. This didn't only add latency to the system, but also the
potential of making the process crash because too much memory could end
up being used the NGAS, triggering the OOM killer to kill our process.

In the case of POST requests this streaming functionality was not
included because the underlying functions in the ngamsHttpUtils module
didn't support this. In the case of a GET request this behavior wasn't
implemented only to avoid writing some code and share it with the POST
branch of the code.

This commit finally changes the behavior of proxy_request to stream the
response back to the original client rather than accumulating it in
memory. Now that the missing functionality has been included into
ngamsHttpUtils both GET and POST requests can be streamed, while their
code is mostly shared.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

13307 of 19455 relevant lines covered (68.4%)

2.05 hits per line

Jobs
ID Job ID Ran Files Coverage
5 434.5 21 Sep 2020 09:44AM UTC 0
68.29
Travis Job 434.5
6 434.6 21 Sep 2020 09:44AM UTC 0
68.37
Travis Job 434.6
7 434.7 21 Sep 2020 09:44AM UTC 0
68.35
Travis Job 434.7
Source Files on build 434
Detailed source file information is not available for this build.
  • Back to Repo
  • Build #434
  • c1e63484 on github
  • Next Build on stream-proxy-request (#436)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc