weaveworks / weave / 3287

53%

master: 45%

push

travis-ci

plug GossipSender leak

GossipChannel.sendDown is the (only) place which creates
GossipSenders. It has two call sites, Send and SendDown, only the
former of which performed a gc of existing senders. Therefore, in
configurations with

- a lot of connection churn, and
- SendDown invocations for these connections, and
- few or no Send invocations

we can leak GossipSenders.

The most likely scenario for this to occur is a peer that, while
having no other connections, is making/accepting connections which get
torn down post handshake, e.g. because IPAM detected a clash.

Fixes #1329.

12 of 12 new or added lines in 1 file covered. (100.0%)

3217 of 6098 relevant lines covered (52.76%)

93403.87 hits per line