• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

cucumber / cucumber-js / 4695
98%

Build:
DEFAULT BRANCH: master
Ran 11 Sep 2020 08:48AM UTC
Jobs 1
Files 75
Run time 8s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
4695

push

travis-ci

GitHub
Compute timestamp Using Date.now (without deriving from duration) (#1431)

This fixes a few bugs with time/duration handling:

* The timestamp of testRunStarted was 0. It's been fixed to be an actual timestamp (Date.now).
* The timestamp of testRunFinshed was not a timestamp, but a duration camouflaged as a timestamp.
* The stopwatch.timestamp() method no longer calculates the timestamp from a duration (which is impossible). Instead it uses Date.now()
* Previously the reports test run duration was based on the testRunFinished timestamp alone, which didn't make sense. A timestamp is not a duration. Instead we calculate it using the difference of the testRunStarted and testRunFinished timestamps

We think there is still some work to do to clean up the timestamp/duration code, but this should be done in a separate PR. This PR simply focuses on getting correct values into the messages.

Co-authored-by: Aslak Hellesøy <1000+aslakhellesoy@users.noreply.github.com>

534 of 634 branches covered (84.23%)

23 of 23 new or added lines in 5 files covered. (100.0%)

1938 of 2053 relevant lines covered (94.4%)

638.91 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4695.1 11 Sep 2020 08:48AM UTC 0
94.4
Travis Job 4695.1
Source Files on build 4695
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #4695
  • 4a12d963 on github
  • Prev Build on master (#4694)
  • Next Build on master (#4725)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc