cucumber / cucumber-js / 4695

98%

push

travis-ci

Compute timestamp Using Date.now (without deriving from duration) (#1431)

This fixes a few bugs with time/duration handling:

* The timestamp of testRunStarted was 0. It's been fixed to be an actual timestamp (Date.now).
* The timestamp of testRunFinshed was not a timestamp, but a duration camouflaged as a timestamp.
* The stopwatch.timestamp() method no longer calculates the timestamp from a duration (which is impossible). Instead it uses Date.now()
* Previously the reports test run duration was based on the testRunFinished timestamp alone, which didn't make sense. A timestamp is not a duration. Instead we calculate it using the difference of the testRunStarted and testRunFinished timestamps

We think there is still some work to do to clean up the timestamp/duration code, but this should be done in a separate PR. This PR simply focuses on getting correct values into the messages.

Co-authored-by: Aslak Hellesøy <1000+aslakhellesoy@users.noreply.github.com>

534 of 634 branches covered (84.23%)

23 of 23 new or added lines in 5 files covered. (100.0%)

1938 of 2053 relevant lines covered (94.4%)

638.91 hits per line