pywbem / pywbemtools / 4337

93%

push

travis-ci

Consolidated retrieval of terminal width

Details:

* There were multiple places that determined table width or terminal width
  in different ways. This change adds a function get_terminal_width() that
  consolidates all these ways. The PYWBEMCLI_TERMWIDTH env var has the
  highest priority. If that is not set, then the USE_TERMINAL_WIDTH config
  variable determines whether the DEFAULT_TABLE_WIDTH config variable is used
  or the dynamically determined terminal width as per click.get_terminal_size().

* As par of this change, moved the definition of the PYWBEMCLI_TERMWIDTH
  env var from pywbemServer into the _utils module, in order to avoid
  circular module references.

* Adjusted the table output width of a testcase, because _display_instances_as_table()
  had used DEFAULT_TABLE_WIDTH (150) and now uses get_terminal_width()
  (120 during the tests).

* Added a testcase for command 'instance shrub' with reduced terminal width
  in order to trigger path folding.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>

21 of 21 new or added lines in 4 files covered. (100.0%)

3122 of 3387 relevant lines covered (92.18%)

2.76 hits per line