9988
64%
master: 66%

Ran 08 Sep 2020 03:48PM UTC

Jobs 1

Files 910

Run time 3min

Badge

Embed ▾

pending completion

Build # 9988

Build Type

push

travis-ci

Committed by

asn-d6

Commit Message

statistics: Properly count all rendezvous cells (avoid undercounting).

tl;dr We were not counting cells flying from the client to the service, but we
were counting cells flying from the service to the client.

When a rendezvous cell arrives from the client to the RP, the RP forwards it to
the service.

For this to happen, the cell first passes through command_process_relay_cell()
which normally does the statistics counting. However because the `rend_circ`
circuit was not flagged with `circuit_carries_hs_traffic_stats` in
rend_mid_rendezvous(), the cell is not counted there.

Then the cell goes to circuit_receive_relay_cell() which has a special code
block based on `rend_splice` specifically for rendezvous cells, and the cell
gets directly passed to `rend_circ` via a direct call to
circuit_receive_relay_cell(). The cell never passes through
command_process_relay_cell() ever again and hence is never counted by our
rephist module.

The fix here is to flag the `rend_circ` circuit with
`circuit_carries_hs_traffic_stats` so that the cell is counted as soon as it
hits command_process_relay_cell().

Furthermore we avoid double-counting cells since the special code block of
circuit_receive_relay_cell() makes us count rendezvous cells only as they enter
the RP and not as they exit it.

Fixes #40117.

Run Details

51012 of 79471 relevant lines covered (64.19%)

40871.01 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
9	9988.9 (MAKEFLAGS="-k -j 2" HARDENING_OPTIONS="--enable-all-bugs-are-fatal --enable-expensive-hardening" ASCIIDOC_OPTIONS="--disable-asciidoc" RUST_VERSION="1.31.0" CHUTNEY_TOR_SANDBOX="0" CHUTNEY_MAKE="test-network-all" COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" TOR_TEST_RNG_SEED="636f766572616765")	08 Sep 2020 03:48PM UTC	0	64.19	Travis Job 9988.9

Source Files on build 9988

Detailed source file information is not available for this build.

torproject / tor / 9988
64%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9988

torproject / tor / 9988 64% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9988

torproject / tor / 9988
64%
master: 66%

README BADGES
x