• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

npm / arborist / #206

Build:
Build:
LAST BUILD BRANCH:
DEFAULT BRANCH: master
Ran 04 Sep 2020 04:58PM UTC
Jobs 1
Files 32
Run time 8s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
#206

push

isaacs
Dont flag workspace edges as suspect unnecessarily

The previous update to flag edges as suspect if the package.json had
changed did not take into account the 'workspace' edges coming from the
root node.

As a result, it would _always_ flag edges as suspect if any workspaces
were in use, resulting in unnecessary work in loadVirtual.

The solution here is to load the actual workspace links when we load the
package.json for the root node, so that we can compare the actual
workspaces to the virtual workspaces present in the lockfile.

This has the side effect of requiring that we fill out the fixtures for
all the virtual workspace loading tests.  This more closely models real
world projects, however, since workspace contents are typically part of
the root project repository anyway.

This does not go as far as detecting when the package.json files of
workspace projects themselves get edited, which will likely have to be
done in a later commit.

2244 of 2244 branches covered (100.0%)

Branch coverage included in aggregate %.

3272 of 3272 relevant lines covered (100.0%)

526.14 hits per line

Jobs
ID Job ID Ran Files Coverage
1 #206.1 04 Sep 2020 04:58PM UTC 0
100.0
Source Files on build #206
Detailed source file information is not available for this build.
  • Back to Repo
  • 16c5e4ba on github
  • Prev Build on
  • Next Build on
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc