RaRe-Technologies / smart_open / 1820
95%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 37
Run time 233min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1820

push

travis-ci

web-flow 
Support installing smart_open without AWS dependencies (#534)

* first pass at removing aws from core dependencies

 - don't export s3_iter_bucket at the top-level. We could probably still make this work, but it would be ugly. This is the only breaking change I can see
 - add suggestive install commands when importing a module that you don't have the deps for

* add python-jose for test suite

- the tests fail locally without it installed

* drop eggs readme

* fix flake8 errors

* add tests for missing package import errors

* remove type annotation from test

* add s3_iter_bucket back to the main package

 - wrap it in a lazy-loaded warning about being deprecated in favor of importing iter_bucket from s3
 - add some more tests

* cleanup from review

* add helpful error when opening uri of unsupported type

 - this isn't the prettiest, but it's still better than a generic error that something might be wrong with a link to the readme?
 - duplicate the schemes list inside of transport.py where the modules are registered. This way if you try to open a URI with that scheme we can show the nice "pip install smart_open[type]" error message.
 - add tests for transport registration and error propagation

* exclude test fixtures from code cov

* Apply suggestions from code review

Co-authored-by: Michael Penkov <m@penkov.dev>

* cleanup from review

 - DRY up the missing import errors by putting the logic in transport.py
 - add MISSING_DEPS to transport modules that can be set to true when handling import errors. This allows the submodule to load properly (so we can inspect the scheme/s) even if it's missing required pacakges.
 - remove double-specified transport schemes (because of MISSING_DEPS)

* cleanup from review

* cleanup from review

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Michael Penkov <m@penkov.dev>

5420 of 5716 relevant lines covered (94.82%)

0.95 hits per line

Jobs
ID Job ID Ran Files Coverage
5 1820.5 (BOTO_CONFIG=/dev/null TOXENV=check_keys,py38-doctest,test_coverage,py38-integration) 0
94.82
 Travis Job 1820.5
Source Files on build 1820
Detailed source file information is not available for this build.