TykTechnologies / tyk / 9792
39%
master: %

LAST BUILD BRANCH: v2.9.4.8
DEFAULT BRANCH: master
Ran
Jobs 1
Files 86
Run time 6s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
9792

push

travis-ci

buger 
[TT-128] Fix reload  implementation (#3269)

This change removes  `startReloadChan` and `reloadDoneChan` because
they are reduntant and blocky. Under high concurrecny they result in the
reload loop to block resultinto new policy changes not be reflected on
the gw.

Also, `reloadQueueLoop` is siimplified and do as what the name implies,
only queuing callbacks to be triggered on the next reload tick.

This also make sure both `reloadQueueLoop` and  `reloadLoop` are
cancellable by accepting `context.Context`

<!-- Why is this change required? What problem does it solve? -->

```
$ go test -v -run TestReloadLoop    ./gateway/
time="Aug 13 12:43:12" level=info msg="Rich plugins are disabled" prefix=coprocess
=== RUN   TestReloadLoop_basic
--- PASS: TestReloadLoop_basic (0.01s)
=== RUN   TestReloadLoop_handler
--- PASS: TestReloadLoop_handler (0.01s)
=== RUN   TestReloadLoop_handlerWithBlock
--- PASS: TestReloadLoop_handlerWithBlock (0.01s)
=== RUN   TestReloadLoop_group
--- PASS: TestReloadLoop_group (1.01s)
PASS
ok      github.com/TykTechnologies/tyk/gateway  1.136s
```

Aslo there is this repo https://github.com/TykTechnologies/reproduce-reload-hangs with steps to reproduce the issue and check if this changes fix it.

<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)

<!-- Go over all the following points, and put an `x` in all the boxes that apply -->
<!-- If you're unsure about any of these, don't hesitate to ask; we're here to help! -->
- [ ] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own
      fork, don't request your `master`!
- [ ] Make s... (continued)

3193 of 18411 relevant lines covered (17.34%)

82.23 hits per line

Jobs
ID Job ID Ran Files Coverage
1 9792.1 (TYK_LOGLEVEL=info LATEST_GO=true) 0
17.34
 Travis Job 9792.1
Source Files on build 9792
Detailed source file information is not available for this build.