2072
96%

Ran 25 Aug 2020 08:11PM UTC

Jobs 5

Files 8

Run time 40s

Badge

Embed ▾

pending completion

Build # 2072

Build Type

push

travis-ci

Committed by

ambv

Commit Message

Address pre-existing trailing commas when not in the rightmost bracket pair

This required some hackery.  Long story short, we need to reuse the ability to
omit rightmost bracket pairs (which glues them together and splits on something
else instead), for use with pre-existing trailing commas.

This form of user-controlled formatting is brittle so we have to be careful not
to cause a scenario where Black first formats code without trailing commas in
one way, and then looks at the same file with pre-existing trailing commas
(that it itself put on the previous run) and decides to format the code again.

One particular ugly edge case here is handling of optional parentheses.  In
particular, the long-standing `line_length=1` hack got in the way of
pre-existing trailing commas and had to be removed.  Instead, a more
intelligent but costly solution was put in place: a "second opinion" if the
formatting that omits optional parentheses ended up causing lines to be too
long.  Again, for efficiency purposes, Black reuses Leaf objects from blib2to3
and modifies them in place, which was invalid for having two separate
formattings.  Line cloning was used to mitigate this.

Fixes #1619

Run Details

4685 of 4914 relevant lines covered (95.34%)

3.81 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	2072.1 (TEST_CMD="pre-commit run --all-files --show-diff-on-failure")	25 Aug 2020 08:11PM UTC	0.0	Travis Job 2072.1
2	2072.2 (TEST_CMD="coverage run -m unittest")	25 Aug 2020 08:12PM UTC	95.12	Travis Job 2072.2
3	2072.3 (TEST_CMD="coverage run -m unittest")	25 Aug 2020 08:12PM UTC	95.12	Travis Job 2072.3
4	2072.4 (TEST_CMD="coverage run -m unittest")	25 Aug 2020 08:12PM UTC	95.2	Travis Job 2072.4
5	2072.5 (TEST_CMD="coverage run -m unittest")	25 Aug 2020 08:12PM UTC	95.16	Travis Job 2072.5

Source Files on build 2072

Detailed source file information is not available for this build.

psf / black / 2072
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2072

psf / black / 2072 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2072

psf / black / 2072
96%

README BADGES
x