2889
94%

Ran 24 Aug 2020 06:50PM UTC

Jobs 1

Files 598

Run time 29s

Badge

Embed ▾

pending completion

Build # 2889

Build Type

push

travis-ci

Committed by

mprimi

Commit Message

Bug: integer overflow for large files

Updates the gRPC protocol to allow downloading files that are over 2GB in size.
The previous version of the protocol was (naively) using int32 for offsets. So anything beyond the 2GB mark would produce an integer overflow server-side.

 - Rename deprecated unit32 fields, they will be ignored by current and future agent in favor of new int64
 - Add a field so that an agent can inform the server it is recent and supports files/ranges over 2GB
 - Block request whose range is over the 2GB mark IFF the target agent is old and does not support it
 - Migrate from int to long where appropriate

Old behavior:
 1) Files smaller than 2GB: no problem
 2) Range below 2GB for larger than 2GB file: no problem
 3) Range above 2GB for larger than 2GB files: error 500, integer overflow

New behavior
 1) Unchanged
 2) Unchanged
 3) (against old agent) Unchanged (but better error message)
 3) (against new agent) successful

Run Details

14582 of 15651 relevant lines covered (93.17%)

0.93 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2889.1 (bintrayUser=[secure] bintrayKey=[secure] sonatypeUsername=[secure] sonatypePassword=[secure] DOCKER_USER=[secure] DOCKER_PASSWORD=[secure] GRGIT_USER=[secure])	24 Aug 2020 06:50PM UTC	0	93.17	Travis Job 2889.1

Source Files on build 2889

Detailed source file information is not available for this build.

Netflix / genie / 2889
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2889

Netflix / genie / 2889 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2889

Netflix / genie / 2889
94%

README BADGES
x