pywbem / pywbemtools / 4135

93%

push

travis-ci

Cleanup and improvements in ConnectionRepository

Details:

* Changed the _load_connections_file() method to succeed if the connections
  file does not exist, instead of raising ConnectionsFileNotFoundError.
  As a consequence, removed the ConnectionsFileNotFoundError exception.
  This was done because having an empty initial ConnectionRepository object is
  consistent with showing an empty state of it when accessing it. Previously,
  all read-only access methods have raised the exception in that state.

* Changed the file_exists() method to no longer load the connections file,
  because it can do its job without that. Adjusted all callers of
  file_exists() to load the connections file if that was needed for their
  job.

* As a consequence of removing the ConnectionsFileNotFoundError exception,
  the __repr__() method now shows an empty connection repo if the file
  does not exist. Previously, it raised the exception.
  Added information about file existence to the returned string.

* Changed the string returned from __repr__() to have all attributes inside
  the parenthesis, and to show the connection names with !r formatting.
  Adjusted testcases to the !r formatting.

* In the setter of property default_connection_name, changed the exception
  that is raised when the specified connection definition does not exist,
  from ValueError to KeyError, for consistency with other such cases.
  Adjusted testcases accordingly.

* In PywbemServer.__init__() and create(), documented that they can raise only
  ValueError and TypeError. As a result, removed the handling of KeyError in
  _load_connections_file().

* Removed the 'ioerrtext' init parameter from ConnectionsFileWriteError,
  requiring the caller to include that in the 'message' parameter if needed,
  in order to have better control on the caller's side for a proper error
  message.

* Changed exception handling of IOError/OSError to always catch both, because
  IOError has been merged into OSError i... (continued)

41 of 41 new or added lines in 1 file covered. (100.0%)

3095 of 3349 relevant lines covered (92.42%)

2.77 hits per line