PayU / prometheus-api-metrics / 850

76%

cron

travis-ci

chore: upgrade prom-client from 11.x to 12.x and update tests. (#43)

* chore: upgrade prom-client from 11 to 12.

Signed-off-by: tarlety@gmail.com <tarlety@gmail.com>

* chore: drop Node.js 6.x and 8.x.

Reason: prom-client 12.0.0 dropped support for end-of-life Node.js versions 6.x and 8.x.
Reference: https://github.com/siimon/prom-client/releases/tag/v12.0.0

Signed-off-by: tarlety@gmail.com <tarlety@gmail.com>

* fix: npm test fail at 'override the default path'.

Symptom:
- ctx.body is not equal to Prometheus.register.metrics().

Root cause:
- since prom-client 12, metrics are collected on scrape of metrics endpoint, not on an interval.
- metrics value change over time.

Solution:
- compare only metric names and lables, not the value.

Signed-off-by: tarlety@gmail.com <tarlety@gmail.com>

* fix: npm test fail due to 'Cannot add the default metrics twice to the same registry'

And fix lint error.

Signed-off-by: tarlety@gmail.com <tarlety@gmail.com>

* test: refactor middleware integration test based on server/configuration.

Refactor 3 tests for express/koa integration test:
1. when start up
2. exclude routes
3. unique metric names

Signed-off-by: tarlety@gmail.com <tarlety@gmail.com>

* test: increase test coverage by removing unused branches.

Signed-off-by: tarlety@gmail.com <tarlety@gmail.com>

* refactor: destructure for more readiblity.

* chore: add Node.js 14 for travis CI.

Co-authored-by: Kobi Carmeli <kobi.carmeli@gmail.com>

159 of 160 branches covered (99.38%)

Branch coverage included in aggregate %.

199 of 199 relevant lines covered (100.0%)

28.91 hits per line