7531
97%

Ran 13 Aug 2015 01:05AM UTC

Jobs 1

Files 79

Run time 2s

Badge

Embed ▾

pending completion

Build # 7531

Build Type

push

travis-ci

Committed by

tilgovi

Commit Message

Improve symmetry for AnnotationSync

This change simplifies the AnnotationSync events and improves the
frame symmetry by giving the guest its own AnnotationSync setup
function, alongside its AnnotationUISync setup, that mirrors the
way its handled in the widget.

Previously, the `loadAnnotations` and `deleteAnnotations` events
were treated specially by AnnotationSync so that it didn't cause
endless loops. Instead, fully embrace the fact that the guest is
not responsible for loading or deleting annotations.

- Remove the setupAnnotation and deleteAnnotation methods, as they are
  no longer used.

- Factor out everything but the event publication of deleteAnnotation
  into a detach method that is the inverse of the anchor method.

- Subscribe to annotationsLoaded and annotationDeleted and invoke anchor
  and detach accordingly.

Coverage Stats

2193 of 3380 relevant lines covered (64.88%)

0.65 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7531.1	13 Aug 2015 01:05AM UTC	0	64.88	Travis Job 7531.1

Source Files on build 7531

Detailed source file information is not available for this build.

hypothesis / h / 7531
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7531

hypothesis / h / 7531 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7531

hypothesis / h / 7531
97%

README BADGES
x