• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

gnosis / dex-services / 4804
31%

Build:
DEFAULT BRANCH: master
Ran 17 Aug 2020 08:54AM UTC
Jobs 1
Files 97
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 Aug 2020 08:42AM UTC coverage: 28.878% (-0.002%) from 28.88%
4804

push

travis-pro

web-flow
Implement BaseUnits for Market route (#1315)

Second to last part of #1082

This PR implements base unit support for the markets route.

Thinking about how we can unify this type of logic, I'm wondering if it would make sense to introduce a trait `into_unit(unit, context)` that all our result types could implement (given the logic of how we convert atoms to base units likely depends on the operation). This would allow us moving logic away from the filters, but I'm not sure how much value there is in that.

### Test Plan
Added unit test + comparing the resulting book (atoms=false) with the visualization on Mesa. In particular picking some large orders and checking that volume and price correspond to the base unit values displayed on the web.

12084 of 48259 branches covered (25.04%)

Branch coverage included in aggregate %.

3371 of 5259 relevant lines covered (64.1%)

27478.23 hits per line

Jobs
ID Job ID Ran Files Coverage
3 4804.3 (OPEN_SOLVER_VERSION=v0.0.11 PRIVATE_SOLVER_VERSION=v0.8.3) 17 Aug 2020 08:54AM UTC 0
28.88
Travis Job 4804.3
Source Files on build 4804
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #4804
  • 06e71acb on github
  • Prev Build on master (#4801)
  • Next Build on master (#4806)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc