tf
/
pageflow
/
2754
99%
master: 99%
master: 99%
|
Ran
|
Jobs
2
|
Files
486
|
Run time
3min
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
tfAbort playAndFadeIn if paused while waiting for play promise On a waveform audio page that has a atmo that is configured to pause during page media playback, atmo resumes when seeking in the playing waveform audio. Wavesurfer pauses the media element while seeking. This causes the atmo to be resumed and immediately faded out again. With the new async promises, the following order of execution can be observed: * Wavesurfer pauses before seek * Atmo plays | * Wavesurfer plays after seed | * Atmo fades out (since it has not yet faded in yet this completes | | immediately) | * Atmo pauses * Atmo fades in Now two problems come into play: * Audio5.js ignores the pause call [2] since it has not yet handled the `play` event and thinks that the player is still paused. * The fade in happens even though the player has been paused in the meantime. This commit only fixes the second problem. Atmo will still play muted after the above scenario. We do not want to patch Audio5.js at this point and also in Paged the atmo continued playing muted. REDMINE-17786 [1] https://github.com/katspaugh/wavesurfer.js/blob/7af166d97/src/wavesurfer.js#L906 [2] https://github.com/codevise/pageflow/blob/master/vendor/assets/javascripts/audio5.min.js#L980
18153 of 18301 relevant lines covered (99.19%)
47.66 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 2754.1 (2.3.1, COVERALLS_PARALLEL=true) | 0 |
99.18 |
Travis Job 2754.1 | |
| 2 | 2754.2 (2.6.5, COVERALLS_PARALLEL=true) | 0 |
99.18 |
Travis Job 2754.2 |
Source Files on build 2754
Detailed source file information is not available for this build.