2753
99%
master: 99%

Ran 13 Aug 2020 07:54AM UTC

Jobs 2

Files 486

Run time 3min

Badge

Embed ▾

pending completion

Build # 2753

Build Type

push

travis-ci

Committed by

Commit Message

Improve error messages when entry template creation fails

* Use conventional keys for validation error messages. Before, the
  error message translation lived below `attributes.models` which is
  reserved for model name translations. Localeapp complains about
  namespaces which contain pluralization keys (i.e. `one`) as well as
  other keys (i.e. the error message) and skips importing the former.

* Use Formtastic helper to actually render the error message in the
  form. Before, submitting the `new` form just re-rendered the form
  without any indication of an error, when an entry template of the
  same type had been created in the meantime. The Formtastic helper
  always prefixes the error message with the attribute name. We
  therefore have to go a bit out of our way to formulate the error
  message accordingly.

* Include a hint in the error message about what has to be done next.

* As a sort of drive-by fix, we also set the page title in the
  `create` and `update` actions. Before, the edit page reverted to an
  untranslated default title when the form rendered in the context of
  the `create` on validation failure.

REDMINE-17306, REDMINE-17793

Coverage Stats

18153 of 18301 relevant lines covered (99.19%)

47.62 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2753.1 (2.3.1, COVERALLS_PARALLEL=true)	13 Aug 2020 07:54AM UTC	0	99.18	Travis Job 2753.1
2	2753.2 (2.6.5, COVERALLS_PARALLEL=true)	13 Aug 2020 07:54AM UTC	0	99.18	Travis Job 2753.2

Source Files on build 2753

Detailed source file information is not available for this build.

tf / pageflow / 2753
99%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2753

tf / pageflow / 2753 99% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2753

tf / pageflow / 2753
99%
master: 99%

README BADGES
x