• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

gnosis / dex-services / 4697
31%

Build:
DEFAULT BRANCH: master
Ran 12 Aug 2020 11:22AM UTC
Jobs 1
Files 93
Run time 29s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Aug 2020 11:10AM UTC coverage: 28.981% (+0.07%) from 28.909%
4697

push

travis-pro

web-flow
Unit parameter with default (#1300)

Recreated PR from #1287 as it was merged into the wrong branch.

Fixes #1106

This PR adds defaults the unit to use base units instead of requiring the atoms parameter.

### Test Plan

Run the price estimator and check the new routes:
```
$ cargo run -p price-estimator
...
$ curl -s 'http://localhost:8080/api/v1/markets/7-1/estimated-buy-amount/1' | jq '.buyAmountInBase'
"373.97582492490005"
$ curl -s 'http://localhost:8080/api/v1/markets/7-1/estimated-buy-amount/1?unit=baseunits' | jq '.buyAmountInBase'
"373.97582492490005"
$ curl -s 'http://localhost:8080/api/v1/markets/7-1/estimated-buy-amount/1?atoms=false' | jq '.buyAmountInBase'
"373.97582492490005"
$ curl -s 'http://localhost:8080/api/v1/markets/7-1/estimated-buy-amount/1000000000000000000?unit=atoms' | jq '.buyAmountInBase'
"373975824924900065280"
$ curl -s 'http://localhost:8080/api/v1/markets/7-1/estimated-buy-amount/1000000000000000000?atoms=true' | jq '.buyAmountInBase'
"373975824924900065280"
$ curl -s 'http://localhost:8080/api/v1/markets/7-1/estimated-buy-amount/1?atoms=true&unit=atoms' | jq
{
  "message": "invalid url query"
}
```

12279 of 48698 branches covered (25.21%)

Branch coverage included in aggregate %.

3352 of 5238 relevant lines covered (63.99%)

27590.29 hits per line

Jobs
ID Job ID Ran Files Coverage
3 4697.3 (OPEN_SOLVER_VERSION=v0.0.11 PRIVATE_SOLVER_VERSION=v0.8.2) 12 Aug 2020 11:22AM UTC 0
28.98
Travis Job 4697.3
Source Files on build 4697
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #4697
  • 5d46189b on github
  • Prev Build on master (#4695)
  • Next Build on master (#4702)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc