• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

gnosis / dex-services / 4665
31%

Build:
DEFAULT BRANCH: master
Ran 12 Aug 2020 06:48AM UTC
Jobs 1
Files 90
Run time 41s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Aug 2020 06:36AM UTC coverage: 28.86% (+0.05%) from 28.814%
4665

push

travis-pro

web-flow
Use new rounding buffer in estimate_buy_amount route (#1261)

Finally :)

### Test Plan
Run the price estimator from master, the price estimator from this PR and the price estimator from master with rounding-buffer-factor set to 0.0. Compare results. We see that in the estimate-buy-amount route the buy amount is the lowest for the master price estimator which is lower than the this PR's default price estimator which is lower than this PR's price estimator with no rounding buffer. Example:

```
# No rounding buffer
curl "localhost:8082/api/v1/markets/4-7/estimated-buy-amount/1?atoms=false"
{"baseTokenId":4,"quoteTokenId":7,"buyAmountInBase":"1.010907","sellAmountInQuote":"1"}
# Solver based rounding buffer
curl "localhost:8080/api/v1/markets/4-7/estimated-buy-amount/1?atoms=false"
{"baseTokenId":4,"quoteTokenId":7,"buyAmountInBase":"1.010707","sellAmountInQuote":"1"}
# Old rounding buffer
curl "localhost:8081/api/v1/markets/4-7/estimated-buy-amount/1?atoms=false"
{"baseTokenId":4,"quoteTokenId":7,"buyAmountInBase":"1.009896","sellAmountInQuote":"1"}
```

Also checked that /markets route is still the same.

11950 of 47571 branches covered (25.12%)

Branch coverage included in aggregate %.

3257 of 5121 relevant lines covered (63.6%)

28016.21 hits per line

Jobs
ID Job ID Ran Files Coverage
3 4665.3 (OPEN_SOLVER_VERSION=v0.0.11 PRIVATE_SOLVER_VERSION=v0.8.2) 12 Aug 2020 06:48AM UTC 0
28.86
Travis Job 4665.3
Source Files on build 4665
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #4665
  • 5b72cb15 on github
  • Prev Build on master (#4659)
  • Next Build on master (#4671)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc