optimizely / javascript-sdk / 2083

78%

push

travis-ci

fix(bucketer): Don't log invalid variation ID warning when bucketed into a traffic allocation range with empty string entityId (#549)

Summary:

Fix an issue introduced in #515. When bucket returns empty string, we shouldn't log a warning about invalid variation ID. Empty string is a valid value for the entityId property of traffic allocation range objects. There is no invalid variation ID in this situation.

Test plan:

Manually tested with A/B tests and rollouts. Added new unit test.

Issues:

OASIS-6890

700 of 800 branches covered (87.5%)

Branch coverage included in aggregate %.

7190 of 7353 relevant lines covered (97.78%)

358.94 hits per line