901
72%

Ran 10 Aug 2020 03:30PM UTC

Jobs 1

Files 546

Run time 2min

Badge

Embed ▾

pending completion

Build # 901

Build Type

push

jenkins

Committed by GitHub

Commit Message

Track ZooKeeper errors as causes of ZKException

Descriptions of the changes in this PR:

### Motivation

Every time a problem with ZK arises you don't see it in the exception chain of the BKException (in this case ZKException) and you end up with errors like:
```
org.apache.bookkeeper.client.BKException$ZKException: Error while using ZooKeeper
        at org.apache.bookkeeper.client.SyncCallbackUtils.finish(SyncCallbackUtils.java:83)
        at org.apache.bookkeeper.client.SyncCallbackUtils$SyncAddCallback.addComplete(SyncCallbackUtils.java:251)
        at org.apache.bookkeeper.client.AsyncCallback$AddCallback.addCompleteWithLatency(AsyncCallback.java:91)
        at org.apache.bookkeeper.client.PendingAddOp.submitCallback(PendingAddOp.java:430)
        at org.apache.bookkeeper.client.LedgerHandle.errorOutPendingAdds(LedgerHandle.java:1784)
        at org.apache.bookkeeper.client.LedgerHandle$5.safeRun(LedgerHandle.java:574)
```

### Changes
Add a "cause" to every ZKException.

### Notes
There are very few places that cannot be fixed because they are still using the old callback based mechanism without CompletableFuture. Those points are not changed in order to make the patch simple but still useful.





Reviewers: Jia Zhai <zhaijia@apache.org>

This closes #2384 from eolivelli/fix/zkexception-chain

Run Details

16 of 16 new or added lines in 3 files covered. (100.0%)

28591 of 39848 relevant lines covered (71.75%)

0.72 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
11	100.0		bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
1	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
1	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
1	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/client/TopologyAwareEnsemblePlacementPolicy.java
1	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
1	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManagerFactory.java
1	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java
2	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/TransactionalEntryLogCompactor.java
2	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LegacyHierarchicalLedgerManager.java
2	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorElector.java
2	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationException.java
3	100.0	bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/BenchThroughputLatency.java
3	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
5	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/verifier/BookkeeperVerifier.java
9	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
14	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java
18	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieInfoReader.java
29	100.0	bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	901.1	10 Aug 2020 03:30PM UTC	0	71.75

apache / bookkeeper / 901
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 901

apache / bookkeeper / 901 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 901

apache / bookkeeper / 901
72%

README BADGES
x