• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ruflin / Elastica / 3960
73%

Build:
DEFAULT BRANCH: master
Ran 10 Aug 2020 07:47AM UTC
Jobs 1
Files 226
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
3960

push

travis-ci

web-flow
Allow string argument in AbstractUpdateAction::setRefresh (#1791)

Ref #1475 

Currently, `AbstractUpdateAction::setRefresh` only accepts boolean values: 
- `true` - to perform an immediate refresh
- `false` - to not refresh at all

The [documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-refresh.html), however, strongly suggests the usage of `wait_for` option to ensure a good cluster performance while doing the refresh operation. But the problem is that `wait_for` is of type `string`; thus, we cannot pass it as an argument to the method.

This modifies `AbstractUpdateAction::setRefresh` so that arguments of type `string` such as `wait_for` can also be passed to the method. Additionally, the return type of its getter counterpart, `AbstractUpdateAction::getRefresh`, has also been modified to mirror the accepted types of the setter.

8 of 8 new or added lines in 1 file covered. (100.0%)

3116 of 4247 relevant lines covered (73.37%)

53.82 hits per line

Jobs
ID Job ID Ran Files Coverage
5 3960.5 (RUN_TEST=coverage COMPOSER_FLAGS="--prefer-stable --prefer-lowest" ES_VERSION=73) 10 Aug 2020 07:44AM UTC 0
73.37
Travis Job 3960.5
Source Files on build 3960
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #3960
  • 9146c807 on github
  • Prev Build on master (#3957)
  • Next Build on master (#3961)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc