gophercloud / gophercloud / 4691
79%

DEFAULT BRANCH: master
Ran
Jobs 4
Files 614
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.512% (+0.1%) from 79.416%
4691

push

travis-ci

web-flow 
Fix/create temp url escaping (#1994)

* Remove container and object escaping from CreateTempURL

- https://github.com/gophercloud/gophercloud/issues/1993
- URL MUST NOT be encoded prior to hashing
- From Swift docs - Do not URL-encode the path when you generate the HMAC-SHA1 signature

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Implement unit test for CreateTempURL

- This test should generate URL with consistent signature and expiry and
  then be asserted

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* refactoring: Statically define HTTP port in test

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Allow stubbing of time on package level for object-storage

This gives enough flexibility to stub time and perform unit tests

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Stub time to static value in test for function CreateTempURL

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Use complex object name with pseudo hierarchical path

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Update expected test results in accounts where TempUrlKey secret was added

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Use different persistent port as in other tests to avoid collisions

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Reset clock implementation in stubbed clock

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Add acceptance test for CreateTempURL

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Close response body manually rather than deferred

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Return byte array from bytes buffer in comparison

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Allow testing of CreateTempURL by passing time.Time as opts

- This way is less hacky than packaging time

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>

* Use assert deep equals to comp... (continued)

19952 of 25093 relevant lines covered (79.51%)

125.25 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4691.1 (COVERALLS_TOKEN=[secure] GO111MODULE=on) 0
79.51
 Travis Job 4691.1
2 4691.2 (COVERALLS_TOKEN=[secure] GO111MODULE=on) 0
79.51
 Travis Job 4691.2
3 4691.3 (COVERALLS_TOKEN=[secure] GO111MODULE=on) 0
79.51
 Travis Job 4691.3
4 4691.4 (COVERALLS_TOKEN=[secure] GO111MODULE=on) 0
79.51
 Travis Job 4691.4
Source Files on build 4691
Detailed source file information is not available for this build.