• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

gnosis / dex-services / 4553
31%

Build:
DEFAULT BRANCH: master
Ran 05 Aug 2020 02:17PM UTC
Jobs 1
Files 88
Run time 36s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Aug 2020 01:48PM UTC coverage: 28.575% (-0.004%) from 28.579%
4553

push

travis-pro

web-flow
Fix how min average fee is passed to solver (#1253)

Solver expects total amount of paid fee while we were passing *earned*
fees, which is half of the total. This lead to many solutions failing
with benign error: max gas price lower than fast price.

See https://github.com/gnosis/dex-open-solver/blob/593d20225/src/match.py#L49.
I found this through checking a recent solution and seeing that the fee in the solution.json was double than what we printed in the logs and that the min-avg-fee-per-order was only upheld assuming the doubled fee.

### Test Plan
CI

11689 of 46808 branches covered (24.97%)

Branch coverage included in aggregate %.

3107 of 4972 relevant lines covered (62.49%)

12113.64 hits per line

Jobs
ID Job ID Ran Files Coverage
3 4553.3 (OPEN_SOLVER_VERSION=v0.0.11 PRIVATE_SOLVER_VERSION=v0.8.2) 05 Aug 2020 02:17PM UTC 0
28.57
Travis Job 4553.3
Source Files on build 4553
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #4553
  • 8d8e931f on github
  • Prev Build on master (#4543)
  • Next Build on master (#4561)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc