|
Ran
|
Jobs
1
|
Files
88
|
Run time
36s
|
Badge
README BADGES
|
push
travis-pro
Fix how min average fee is passed to solver (#1253) Solver expects total amount of paid fee while we were passing *earned* fees, which is half of the total. This lead to many solutions failing with benign error: max gas price lower than fast price. See https://github.com/gnosis/dex-open-solver/blob/593d20225/src/match.py#L49. I found this through checking a recent solution and seeing that the fee in the solution.json was double than what we printed in the logs and that the min-avg-fee-per-order was only upheld assuming the doubled fee. ### Test Plan CI
11689 of 46808 branches covered (24.97%)
Branch coverage included in aggregate %.
3107 of 4972 relevant lines covered (62.49%)
12113.64 hits per line
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 3 | 4553.3 (OPEN_SOLVER_VERSION=v0.0.11 PRIVATE_SOLVER_VERSION=v0.8.2) | 0 |
28.57 |
Travis Job 4553.3 |